Correct a typo in VpcEndpointServiceAllowedPrinciple #5396
Conversation
SDK-generated classes are now VpcEndpointServiceAllowedPrincipal, old classes still work but warn to upgrade to the correct spelling.
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5396 +/- ##
=======================================
Coverage 24.35% 24.35%
=======================================
Files 364 364
Lines 145768 145768
=======================================
Hits 35508 35508
Misses 110162 110162
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| prov.Resources[k] = v | ||
| } | ||
|
|
||
| // Correct a typo: Principle -> Principal. |
There was a problem hiding this comment.
I don't believe you actually need this. I believe that if you edit the definition in resources.go above you'd get the right thing since we have AutoAliasing and the old name is saved in the bridge-metadata
There was a problem hiding this comment.
Since a human is doing it it sounds better to have it explicit tbh.
I have my doubts whether those are readable without tooling. Anyway not worth reworking IMO. |
SDK-generated classes are now VpcEndpointServiceAllowedPrincipal, old classes still work but warn to upgrade to the correct spelling.
Fixes #5394